search

tinted-theming / base16-helix

base16 colors for helix
MIT License
11 stars 6 forks source link

Fix themes to support primary search/selection #12

Open nazarewk opened 3 months ago

nazarewk commented 3 months ago

I thought it was [something wrong with helix install](see also https://github.com/helix-editor/helix/pull/5309), but looks like numerous upstream themes have this issue too https://github.com/helix-editor/helix/issues/3842 (including default theme).

this seems to be refered to as highlighting for the primary cursor

here seems to be an example fix https://github.com/helix-editor/helix/pull/5573/files

nazarewk commented 3 months ago

actually this is explicitly set to the same as normal selection https://github.com/tinted-theming/base16-helix/blob/2b75de932e2b3d1312fd3fd0ae3ff4d88f0a8b48/templates/default.mustache#L62-L63 it should be different to even go through hx --tutor

nazarewk commented 3 months ago

another option is distinguishing cursor for selections:

"ui.cursorline" = { bg = "my_gray3" }
"ui.cursorline.primary" = { bg = "my_black" }
"ui.cursorline.secondary" = { bg = "my_black" }
JamyGolden commented 3 weeks ago

@krgn (tagging you since github doesn't auto tag maintainers people on github issues)