tinted-theming / base16-helix

base16 colors for helix
MIT License
11 stars 6 forks source link

None of the base16 themes deal well with bufferline. Selected buffer not visible #4

Closed paletochen closed 1 year ago

paletochen commented 1 year ago

Hi, I noticed that none of these base16 themes highlight the buffer selected in the bufferline, making them not suitable when working in helix and multiple buffers at once.

Screenshot where you can see the bufferline at the top and no way how to distinguish the active one

image

Below any other theme which shows it

image

Could you please have a look at it?

Thanks

paletochen commented 1 year ago

One recommendation

"ui.bufferline" = { fg = "base04", bg = "base00" }
"ui.bufferline.active" = { fg = "base00", bg = "base03", modifiers = ["bold"]}

This would look like in base16-google-dark (as an example) like below:

image

krgn commented 1 year ago

Hi @paletochen! Thank you for the suggestions. Could you pull this PR and see if the rendered themes fit your needs? Thanks

paletochen commented 1 year ago

Hi @paletochen! Thank you for the suggestions. Could you pull this PR and see if the rendered themes fit your needs? Thanks

Hi @krgn I looks perfect! :+1:

krgn commented 1 year ago

Fixed in #5