search

tinted-theming / base16-i3

MIT License
124 stars 16 forks source link

Separate out more config components and combine them using mustache partials #5

Closed mnussbaum closed 6 years ago

mnussbaum commented 6 years ago

This PR separates the bar colors and client properties sections of the i3 config into their own separately renderable chunks. To avoid duplicating template code, this PR also renders the default, full template as a combination of the component templates using mustache partials.

My motivation for the PR is that I'd like to include all of the config settings defined in the full template except for the i3 status command. In order to make that possible I need to fetch each config component separately and interpolate them together.

The PR also re-renders all the generated configs from its version of the template. The template hex codes seem to render downcase now which unfortunately makes this diff appear larger then it should.

khamer commented 6 years ago

Merged in. Thanks for contributing.

khamer commented 6 years ago

Hey @mnussbaum - what engine did you use for this? It seems like mustache partials aren't actually supported by chriskempson/base16-builder-php for example.

mnussbaum commented 6 years ago

I used base16-builder-go, which does support partials, to build this PR.

That's unfortunate the PHP builder doesn't support them :(. If the lack of support in the PHP builder interferes with this project feel free to revert the partials