search

tinted-theming / home

Style systems and smart build tooling for crafting high fidelity color schemes and easily using them in all your favorite apps.
MIT License
254 stars 12 forks source link

(docs) call the input to builders, `schemes` consistently #15

Closed joshgoebel closed 2 years ago

joshgoebel commented 2 years ago

Attempts to resolve #14.

belak commented 2 years ago

What would you think of adding scheme-slug-underscored to this PR, rather than the next spec change?

joshgoebel commented 2 years ago

Why? I think typically small PRS are better than large PR's.

joshgoebel commented 2 years ago

I think perhaps we need to start releasing spec versions so that main can sometimes be in between versions.

joshgoebel commented 2 years ago

Or just a next branch or something.

joshgoebel commented 2 years ago

I actually thought of this as a minor documentation fix but I guess if we're being picky you could argue that it's a new version of the spec. But that's why I say that we need releases or a separate branch.

I don't think it benefits us to treat such tiny changes as spec versions.

belak commented 2 years ago

Ah, wait, I might have been thinking of a different PR...

EDIT: yeah, my bad - I was thinking of https://github.com/base16-project/base16/pull/16 which accidentally got closed when the builder PR was merged in.

belak commented 2 years ago

I actually thought of this as a minor documentation fix but I guess if we're being picky you could argue that it's a new version of the spec. But that's why I say that we need releases or a separate branch.

I don't think it benefits us to treat such tiny changes as spec versions.

Yes, I agree - it should be possible to work on scheme changes without being forced to release them as a new version. I don't really want to figure out a git workflow for that just yet though.

joshgoebel commented 2 years ago

I don't really want to figure out a git workflow for that just yet though.

I don't know that we need a "workflow"... just let main float, and do a Github "release" when we release a new version... perhaps a minor update to the readme to explain this.