search

tinted-theming / home

Style systems and smart build tooling for crafting high fidelity color schemes and easily using them in all your favorite apps.
MIT License
254 stars 12 forks source link

Add `scheme-description` #16

Closed joshgoebel closed 2 years ago

joshgoebel commented 2 years ago

We need a way to add/propose small changes to the spec (like this) without getting caught up in a huge process.

actionless commented 2 years ago

i think we need the same for templates' config.yaml as well

belak commented 2 years ago

It may take a while, but we should update as many of the schemes as we can with descriptions from the original repos.

belak commented 2 years ago

We need a way to add/propose small changes to the spec (like this) without getting caught up in a huge process.

In general I agree, but we don't usually have many spec changes going in so quickly. I'm guessing after an initial pain period, it'll settle down.

belak commented 2 years ago

At least on my end this says "Merge without waiting for requirements to be met (administrators only)" which doesn't make sense because all the branch restrictions are met... Ping me (or another admin) when you think it's ready to Go in and I'll merge it (and merge the changes to the Go builder).

joshgoebel commented 2 years ago

At least on my end this says "Merge without waiting for requirements to be met

It's confusing thinking one of actionless's thoughts hasn't been addressed but from where I can see they are both marked resolved, so I'm lost as well...

belak commented 2 years ago

This is the PR I was thinking of when I mentioned this in the other one:

What would you think of adding scheme-slug-underscored to this PR, rather than the next spec change?

joshgoebel commented 2 years ago

Same answer. If the problem is the version bump then I'll back that out... and I think we need to accept letting main "float"... or create a branch to work against for new versions...

belak commented 2 years ago

Same answer. If the problem is the version bump then I'll back that out... and I think we need to accept letting main "float"... or create a branch to work against for new versions...

Fair enough - let's just bump to 0.10.2-pre1 (or 0.10.2-dev), or something like that and I'll add another PR for scheme-slug-underscored.

joshgoebel commented 2 years ago

Yeah on the other hand we probably shouldn't be too worried about running out of version numbers just yet. 😂

joshgoebel commented 2 years ago

Is this approved as is then or do I need to change the version

belak commented 2 years ago

I merged it in- in the future, let's suffix the version with -dev and build the changelog (and remove the suffix) when we're ready to make it stable so we can batch changes.

joshgoebel commented 2 years ago

Or maybe just not bump the version at all until release time?