search

tinted-theming / home

Style systems and smart build tooling for crafting high fidelity color schemes and easily using them in all your favorite apps.
MIT License
254 stars 12 forks source link

Why is "File Guidelines" not a versioned part of the spec? #17

Closed joshgoebel closed 2 years ago

joshgoebel commented 2 years ago

https://github.com/base16-project/base16/blob/main/file.md

Should this not be versioned along with the rest of the spec?

actionless commented 2 years ago

yup, i think that's the must

if version value not provided in scheme/template - builder should fallback it to smaller possible version

joshgoebel commented 2 years ago

I was referring to the spec itself. Individual schemes are a different matter.

actionless commented 2 years ago

yes, version of the spec

joshgoebel commented 2 years ago

Actually I think most of the time we could auto-version schemes. If a scheme has a newer feature, then it's from a newer version. This works as long as there is never ambiguity about what a key means between versions.

And if we own all the themes it may simply be possible that they are always up-to-date because we simply guarantee it.

belak commented 2 years ago

Arguably, this is really a part of the builder spec - maybe we should merge it into builder.md?

joshgoebel commented 2 years ago

Probably since if it changes the builder spec also has to change

belak commented 2 years ago

I believe this would also be fixed by #23

belak commented 2 years ago

I'm going to close this for now - at the moment we're operating under the assumption that the "File Guidelines" are a part of the builder spec and the versioning is in line with that. We will merge the two files at some point in the near future.

joshgoebel commented 2 years ago

If that so would it hurt to just copy the version number over?

joshgoebel commented 2 years ago

Though if that file is about to disappear, this can wait until then. :)