search

tinted-theming / home

Style systems and smart build tooling for crafting high fidelity color schemes and easily using them in all your favorite apps.
MIT License
254 stars 12 forks source link

Update "logo" to look good in dark mode as well #33

Closed joshgoebel closed 2 years ago

joshgoebel commented 2 years ago

Any graphics people on the team? I think it'd be much nicer if we could replace this white bg with transparent and remove the "base16" from the graphic... that way the colors/logo/whatever still looks good in light or dark mode in the browser.

Snap_2022-07-03_918x268

belak commented 2 years ago

It should still be possible to make the base16 text look good in both light-mode and dark-mode (you can do black text, with a white border or the reverse).

NNBnh commented 2 years ago

I saw this repo's README.md can change images between dark and light theme. I don't know what kind of black magic they are using but it's pretty slick.

NNBnh commented 2 years ago

SmartSelectImage_2022-07-04-14-23-04

I notice that the org logo's black text also don't look good in dark mode as well.

joshgoebel commented 2 years ago

Ha, I hadn't noticed the org logo until just now... I thought you drew that at first.

belak commented 2 years ago

This is how that other repo did it: https://github.blog/changelog/2021-11-24-specify-theme-context-for-images-in-markdown/

I think the trick with a border will work best because we can be consistent between the org logo and the repo logo.

joshgoebel commented 2 years ago

Don't have this problem anymore. :)