tinted-theming / home

Style systems and smart build tooling for crafting high fidelity color schemes and easily using them in all your favorite apps.
MIT License
254 stars 12 forks source link

Epic: Reabsorb/merge with Base24 project #49

Closed joshgoebel closed 6 months ago

joshgoebel commented 2 years ago

Ref #45.

joshgoebel commented 2 years ago

https://github.com/Base24/base24#scheme-repositories

Could we make a uni-repo like we've done for base16-schemes and then move all of these into a single repo for easier maintenance?

joshgoebel commented 2 years ago

@FredHappyface Could this be assigned to you perhaps since you're going to the main point person we work with to get this done?

FredHappyface commented 2 years ago

Yeah I'd be happy with that. Would you be happy with me being a member of the base16-project org

I'd be pretty happy to take:

joshgoebel commented 2 years ago

invite sent.

belak commented 2 years ago

I want to make sure we're all on the same page before we move ahead with all of this - at a bare minimum, we need to resolve #54 first, should either update the spec to be scheme-family-generic (or completely redesign the builder spec to integrate with other style specs), and figure out how we want to store schemes from other "families".

joshgoebel commented 2 years ago

This is why I see style specs owning/explaining the scheme format... so merging with a new style system is just transferring/adding a repo... IMHO we shouldn't need to be changing the builder spec constantly (every time a style family is added).

at a bare minimum, we need to resolve #54 first,

I still think it makes sense to begin by transferring the repo here (momentum) - even if later we decided to put all the specs in one place - so personally I'm not sure this should be a blocker.

I had the thought that we could also vendor the specs into a single repo as submodules... and the sub-modules would only need to be updated when a new spec version was released - though I'm still liking the idea of one repo per spec.

I wasn't happy at all with the PR process for working on a large new spec, that's why I created a base17 repo - and (at least for me) I think new specs should likely be developed in separate repos - even if later (once they mature) they find a home in a mono-repo.

and figure out how we want to store schemes from other "families".

I had simply imagined a separate base24_schemes repo... so all the separate schemes move into a single repo, the same way we did with base16.

FredHappyface commented 1 year ago

Other points I currently don't have enough opinion or knowledge on at this point. Happy to give a base24 builder in go a go... but iirc this is underway

FredHappyface commented 1 year ago

Hi anything else you need from me on this? If not I'll go ahead and unassign myself 🙂

JamyGolden commented 6 months ago

These are basically all done now, so I'll close this issue.