search

tinted-theming / home

Style systems and smart build tooling for crafting high fidelity color schemes and easily using them in all your favorite apps.
MIT License
252 stars 12 forks source link

Update builder-spec to 0.12.0 #99

Open JamyGolden opened 2 months ago

JamyGolden commented 2 months ago

General

@belak @FredHappyface and I had a discussion about the next Tinted Theming specification step. We discussed various possibilities but ultimately decided it was a good idea to expand the base16 builder spec to allow for more template color flexibility for base16 (and base24 since it's a superset of base16).

The general consensus was that we expand the spec, while being base16 backwards compatible, to include an "overrides" object, containing a set of pre-defined values where a scheme creator can make some adjustments to the scheme which would allow them to ultimately change how a theme is generally built using a tinted-builder. This change ultimately addresses https://github.com/tinted-theming/home/issues/10, https://github.com/tinted-theming/home/issues/11, https://github.com/tinted-theming/home/issues/24 and https://github.com/tinted-theming/home/issues/48. The pre-defined values will be heavily influenced by the existing styling specification.

This draft PR kicks off the continued discussion around this spec to move forward with.

PR specific

I've taken the values from the styling specification and added them to the overrides section basically word-for-word and added the current behaviour as default values.

In the current spec default-background: base00, lighter-background: base01, selection-background: base02 and brightest-foreground: base07 are single values with a single base0* mapping. So it might make sense to keep it out? Or maybe we should include it so when we potentially expand on an override in those sections, minimal change is required?

There are things like markup-italics which is oddly specific. If we decide it doesn't make sense to add, then we should probably update the styling spec based on our decisions here too.

FredHappyface commented 5 days ago

Happy with the direction this is taking, I think this pr needs a few minor tweaks before it is ready to merge :)