tinted-theming / schemes

A common location to store all color scheme data for the Tinted theming project
90 stars 25 forks source link

(base16-github) Readability fix needed #35

Open chawyehsu opened 2 days ago

chawyehsu commented 2 days ago

Yesterday I spent some time getting my base16-snazzy-scheme and base16-concfg revamped, and noticed there's an unresolved issue of color mapping I opened years ago about the base16-github scheme. I just post it here for xref and see if anyone is interested in getting it fixed. I don't currently use this scheme though.

https://github.com/chawyehsu/base16-concfg/issues/3

JamyGolden commented 2 days ago

Thanks for creating an issue about this. I should create an issue to go through all the schemes and if there isn’t a good reason to avoid the suggestions in the styling guidelines, then change the theme, in line with the themes colours, to fit the styling guidelines. I’ll have a look at creating a PR to fix this later this week.