search

tinted-theming / tinted-fzf

base16 colorschemes for fzf
https://github.com/base16-project/base16
MIT License
135 stars 9 forks source link

Append to FZF_DEFAULT_OPTS variable #11

Closed ayyess closed 4 years ago

ayyess commented 4 years ago

base16-fzf should append to the FZF_DEFAULT_OPTS variable rather than overwriting it.

fnune commented 4 years ago

I believe you rebased on your own master, since your diff doesn't include some of the new themes. I'll merge this one and then add a commit to fix the diff.

ayyess commented 4 years ago

Thanks for finishing up the missing files for me.

fnune commented 4 years ago

Related fix for fish https://github.com/fnune/base16-fzf/commit/954e5cbe8a75beb32aa1c3750d76bcbc9d32cabb

JamyGolden commented 8 months ago

@ayyess why was this change done? Why append rather than overwrite? (The only thing I can think of is in case the user set any colors to properties not set by base16-fzf, but it seems like a strange case)