Closed JamyGolden closed 2 years ago
Are you targeting systems without bash entirely? Couldn't most of the hook scripts just be bash only even if the primary shell was fish? And prevent all the duplication?
Fish has been a first class citizen in the project (outside of the generated files) so I've been keeping it that way. I'm not really sure how to get an idea of shell usage with this project, but I think a lot of fish shell users fish shell and it could be a selling point that it's in fish? It's difficult to know this without people actively involved in creating issues or being part of discussions or knowing usage share.
Discussing the need for .fish
files in this repo outside of profile_helper.fish
makes sense (though as I mentioned above I think we'd need to discuss how to even make a decision like that), but not part of this PR so I'll merge.