search

tinted-theming / tinty

A base16 and base24 color scheme manager
MIT License
57 stars 5 forks source link

[Bug report] text with the generated colors isn't very readable #81

Open salahoued opened 1 week ago

salahoued commented 1 week ago

Describe the bug

I use tinty to generate custom schemes from the wallpaper, but sometimes the generated colors (base08-base0F) in a dark color scheme aren't very readable when using base00 as background color

Expected behavior

When generating a dark color scheme the color from base08 to base0F should be showing and readable with the backgroud base00, just like the foreground color base07. and those colors 'should' 'lighter'.

Screenshots

konsole alacritty

Terminal: Konsole (most of the time) and alacritty

Minimal configuration file

# Global settings
shell = "bash -c '{}'"
# default-scheme = "base16-mocha"
#hooks = [ "command1", "command2" ]

# Item configurations
[[items]]
name = "tinted-shell"
path = "~/.local/share/tinted-theming/tinty/repos/tinted-shell"
themes-dir = "scripts"
hook = "source %f"
supported-systems = ["base16"]

[[items]]
name = "base16-rofi"
path = "~/.local/share/tinted-theming/tinty/repos/base16-rofi"
themes-dir = "colors"
hook = "cp -r %f ~/.config/rofi/colors.rasi"

[[items]]
name = "base16-fzf"
path = "~/.local/share/tinted-theming/tinty/repos/base16-fzf"
themes-dir = "bash"
hook = "cp -r %f ~/.fzfcolors.sh && source ~/.fzfcolors.sh"
supported-systems = ["base16"]
JamyGolden commented 2 days ago

Thanks for creating the issue. Yeah totally, 08-0F should be readable on base00. It’s finding the closest colours to red, orange, yellow, etc. but if it can’t it defaults to the closest value, however I can make sure that if it finds something, the brightness is above some threshold otherwise it forces it. I’ll look more closely into this in the next week or so.