search

tintinweb / scapy-ssl_tls

SSL/TLS layers for scapy the interactive packet manipulation tool
GNU General Public License v2.0
419 stars 156 forks source link

Upgrade to scapy v2.4.0 #132

Closed googlebleh closed 6 years ago

googlebleh commented 6 years ago

Trying to address issue #117 by upgrading the interface for scapy v2.4.0

googlebleh commented 6 years ago

I've tested examples/full_rsa_connection_with_application_data.py, but I'm sure this has poor coverage. Consider this a WIP.

googlebleh commented 6 years ago

Current build failure looks like a problem with how setup.py patches scapy's config.py. As I work on that, should I make a separate PR or just add to this one?

tintinweb commented 6 years ago

Hi @googlebleh,

appreciate your help.

ad setup.py - looks like the config.py changed with the new scapy version and thats why the hacky patch breaks the files syntax (seems like a missing linebrk). we're searching for load_layers = [...] and lex-patching , scapy_ssl_tls at the end not adding/replacing any linebrks (see setup.py). should be easy to fix, however maybe there is a more elegant way to autoload new layers @gpotter2 ?

edit: scapy setup.py changed from dblquot to snglquot strings. thats why its failing. setup.py#L102 needs to be changed to snglquot find. since its a change introduced with the new scapy it should be handled within this PR.

gpotter2 commented 6 years ago

We currently have no other elegant way (apart from using a scapy config file) to auto load non scapy layers :/

googlebleh commented 6 years ago

Thanks for both your comments! I've implemented them and will continue on working to pass the integration tests

PS: I understand all the performance implications of __slots__. My comment might have been written in a fit of frustration :). I have removed it in my most recent commit.