Closed tintinweb closed 9 years ago
tintin » scapy-ssl_tls #4 SUCCESS This pull request looks good (what's this?)
Looks good. Should we settle on merging bug fixes and doc changes directly, and only raise PRs for feature changes? What do you think?
Unrelated, but I just had a check at the Jenkins output, and it doesn't seem to run the tests:
GitHub pull request #18 to tintinweb/scapy-ssl_tls
Building remotely on s-cc3038a5 in workspace /scratch/jenkins/workspace/tintinweb/scapy-ssl_tls
Fetching changes from the remote Git repository
Fetching upstream changes from git://github.com/tintinweb/scapy-ssl_tls.git
Opening connection
Done: 0
Counting objects
Done: 0
Finding sources
Done: 0
Writing objects
Done: 0
remote: Updating references
Merging refs/tags/changes/4
Checking out Revision 69d480ce5de9db41607686e76b444b4a532bae15 (master)
[scapy-ssl_tls] $ /usr/bin/tenant-isolate /usr/bin/env bash /tmp/hudson3874771053047473417.sh
**> virtualenv exists
Requirement already satisfied (use --upgrade to upgrade): pycrypto>=2.6 in ./.env/lib/python2.7/site-packages (from -r requirements.txt (line 1))
Requirement already satisfied (use --upgrade to upgrade): scapy>=2.2.0 in ./.env/lib/python2.7/site-packages (from -r requirements.txt (line 2))
Cleaning up...
Requirement already satisfied (use --upgrade to upgrade): nose in ./.env/lib/python2.7/site-packages
Cleaning up...
----------------------------------------------------------------------
Ran 0 tests in 0.000s
OK
Putting comment on the pull request
Finished: SUCCESS
Do you know if it calls setup.py test?
nope, it is manually running nosetest on tests/scapy/layers. since the folder structure changed it does not pick up tests anymore. will change it to run setup.py test later today.
Agree, does not make much sense to create PRs for doc issues.