fix pip dependencies and move to pycrpyptodomex

tintinweb / scapy-ssl_tls

SSL/TLS layers for scapy the interactive packet manipulation tool

GNU General Public License v2.0

419 stars 156 forks source link

fix pip dependencies and move to pycrpyptodomex #82

Closed tintinweb closed 8 years ago

tintinweb commented 8 years ago

This is PR #81 fixes #79 on master plus relevant codechanges to move to pycryptodomex #80

alexmgr commented 8 years ago

+1, was about to do that also.

I think we should still warn if pycrypto is installed, because we're nice ;) It's old, unmaintained and contains exploitable vulnerabilities: see https://github.com/dlitz/pycrypto/pull/192

import pkg_resources
try:
    pkg_resources.require("pycrypto")
    print("Get rid off it!")
except (pkg_resources.DistributionNotFound, pkg_resources.VersionConflict):
    pass

tintinweb commented 8 years ago

oh, did not know that pycrypto is unmaintaned. feel free to add the warning (setup.py?) to this PR and merge it when ready 👍

tintinweb commented 8 years ago

added warning to setup.py but it is only visible if you python setup.py install it. I did not find a way to print something when installing with pip install ..