search

tintinweb / scapy-ssl_tls

SSL/TLS layers for scapy the interactive packet manipulation tool
GNU General Public License v2.0
419 stars 156 forks source link

Jawohl! (aka py3compat for release/1.2.3) #93

Closed cniemira closed 7 years ago

cniemira commented 7 years ago

This branch includes relatively full py3 support. There's a weird issue in the tests where the output whitespace doesn't align, which I think has to do with the content of list elements, but I haven't yet traced it down.

tintinweb commented 7 years ago

Thanks for the PR 👍 we'll have to rebase this off release/1.2.3 first as it is currently conflicting with our codebase. Fyi our current master is undergoing major changes with tls1.3 support so I'd like to first test this out on release/1.2.3 and if thats works out we'll also add py3 support for master later. would you mind rebasing your changes off our latest release/1.2.3 in order to make the PR green? I'd be happy to start working on the py3 compat layer once thats done.

tin

tintinweb commented 7 years ago

I'll close this PR and open up an experimental py3compat branch. Getting this one in a mergeable state would require more effort than replaying the changes on master. Plus this way we do not need to fix issues introduced by the py2to3 transformation ( session.print (ed==False:)) and import issues.

Feel free to contribute to the py3compat branch.

see https://github.com/tintinweb/scapy-ssl_tls/commit/4fa2ec987523ac381acdb794d5e7da89d8ae92dd