search

tintinweb / vscode-decompiler

Decompile things directly from VSCode
https://marketplace.visualstudio.com/items?itemName=tintinweb.vscode-decompiler
155 stars 27 forks source link

Append .bat to windows/ghidra configuration resolves #19 #20

Closed tamckenna closed 2 years ago

tintinweb commented 2 years ago

thanks for taking the time to submit a PR! much appreciated.

path guessing only works on macos/linux. For win32 it is required to configure the path manually anyway because there's no generic way to guess it. Hence, I would avoid adding magic code that auto-appends .bat and require the user to correctly configure the path to the ghidra headless utility instead.

cheers 🙌