search

tintinweb / vscode-inline-bookmarks

Customizable inline Bookmarks for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=tintinweb.vscode-inline-bookmarks
GNU General Public License v3.0
46 stars 14 forks source link

Cannot ignore .d.ts extension #21

Closed SamHasler closed 4 years ago

SamHasler commented 4 years ago

I've set the list of ignored extensions to .d.ts but I'm still seeing them in the panel list after clicking on the refresh button.

tintinweb commented 4 years ago

Hey @SamHasler,

this sounds like a bug. looks like this setting may not have an effect on the treeview 🤔 Do you see any decorations in that file?

did you first add a bookmark to a file and then added it to the ignore list?

SamHasler commented 4 years ago

It had already remembered seeing several @deprecated comments in .d.ts files that I had opened whilst debugging but hadn't written myself. I then added .d.ts to the ignored extensions expecting it to then filter out those file.

tintinweb commented 4 years ago

this feature is not really meant to filter the view but to completely exclude file-extensions from being processed. however, it can also be used in that way. I've fixed your specific issue with #30aac5 clearing bookmarks for existing files if we find out the extension is to be ignored.

SamHasler commented 4 years ago

Thank you! I think this will be less confusing for people trying to filter out files after they've already been remembered.