search

tintinweb / vscode-inline-bookmarks

Customizable inline Bookmarks for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=tintinweb.vscode-inline-bookmarks
GNU General Public License v3.0
45 stars 14 forks source link

"List Bookmarks" command should respect "Show Bookmarks for Visible Editors / All Files" #32

Closed AlexanderArvidsson closed 3 years ago

AlexanderArvidsson commented 3 years ago

Currently, when specifying that bookmarks should only show for the current file, the list bookmarks command shows bookmarks for all files which can get messy if you have lots of bookmarks that are similar.

Can we make sure that the list command respects the setting, or get another setting that filters for only the visible editors? My workflow is that I jump to files through vim bindings and then open a list, search and go to the bookmark. This is problematic when the list shows all files, since I have comments that are similar. It forces me to find the right file which takes time.

image image

Also, great extension, exactly what I have been looking for, and something that other bookmarks extensions are lacking (those extensions have bookmarks that are jumping around with git changes and even when editing locally sometimes because they are not inline).

tintinweb commented 3 years ago

Hey @AlexanderArvidsson,

are you talking about the "list" or "select bookmark" command?

tintinweb commented 3 years ago

I went ahead and implemented it for both "list" and "select". Please note that the "Show bookmarks for visible editors" setting only applies to the bookmarks treeview object.

cheers, tin