Closed rkodey closed 3 years ago
awesome 🙌 this is great @rkodey! I am thinking about turning the setting from bool
to enum
just in case there'll be another line mode to avoid :) I'll try to get this tested later today.
Cool - glad I could contribute an idea!
The next thing I was considering... an option to wrap-around. So, jumping to "Next" from the last bookmark would jump to the first bookmark.
Perhaps that's a good reason to use your enum
instead of bool
!
The next thing I was considering... an option to wrap-around. So, jumping to "Next" from the last bookmark would jump to the first bookmark.
Perhaps that's a good reason to use your
enum
instead ofbool
!
Happy to receive a PR on this. Would probably make sense to make this the default behavior 🤔
Ok - I'll rebase on your enum update and fiddle with the wrap-around feature a bit. Notepad++ wraps by default, so I agree that might be the best default here as well. Perhaps an option to turn off wrapping as part of your enum... but "keep it simple" might suggest making wrapping the default, then wait for user feedback.
Probably later this week...
Resolves #40 Fixes #38 (included)