search

tintinweb / vscode-inline-bookmarks

Customizable inline Bookmarks for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=tintinweb.vscode-inline-bookmarks
GNU General Public License v3.0
45 stars 14 forks source link

Feature: Line Mode (#40) #41

Closed rkodey closed 3 years ago

rkodey commented 3 years ago

Resolves #40 Fixes #38 (included)

tintinweb commented 3 years ago

awesome 🙌 this is great @rkodey! I am thinking about turning the setting from bool to enum just in case there'll be another line mode to avoid :) I'll try to get this tested later today.

rkodey commented 3 years ago

Cool - glad I could contribute an idea!

The next thing I was considering... an option to wrap-around. So, jumping to "Next" from the last bookmark would jump to the first bookmark.

Perhaps that's a good reason to use your enum instead of bool!

tintinweb commented 3 years ago

The next thing I was considering... an option to wrap-around. So, jumping to "Next" from the last bookmark would jump to the first bookmark.

Perhaps that's a good reason to use your enum instead of bool!

Happy to receive a PR on this. Would probably make sense to make this the default behavior 🤔

rkodey commented 3 years ago

Ok - I'll rebase on your enum update and fiddle with the wrap-around feature a bit. Notepad++ wraps by default, so I agree that might be the best default here as well. Perhaps an option to turn off wrapping as part of your enum... but "keep it simple" might suggest making wrapping the default, then wait for user feedback.

Probably later this week...