"inline-bookmarks.search.excludes" and "inline-bookmarks.search.includes" settings not working

tintinweb / vscode-inline-bookmarks

Customizable inline Bookmarks for Visual Studio Code

https://marketplace.visualstudio.com/items?itemName=tintinweb.vscode-inline-bookmarks

GNU General Public License v3.0

45 stars 14 forks source link

"inline-bookmarks.search.excludes" and "inline-bookmarks.search.includes" settings not working #44

Closed kumardot93 closed 2 years ago

tintinweb commented 2 years ago

this is only being used in the scanWorkspace feature where the extension would try to find bookmarks in files in the current workspace. I guess that's not very clear from the description of the setting or is it not working correctly for you when scanning the workspace?

kumardot93 commented 2 years ago

I have tried to avoid bookmarks from the env folder because it was taking too long to search. env folder contains python packages. My settings.json file contains the following settings:


"inline-bookmarks.search.excludes": [
        "**/env/**",
        "**/frontend/node_modules/**",
    ],

I have checked many times, it is now working or me.

tintinweb commented 2 years ago

Hey @kumardot93,

I cannot seem to reproduce. Files matching the pattern defined in search.excludes seem to be excluded from "workspace scanning". They will, however, show up if they're found in any editor and they will be added to the bookmarks view if a file containing a bookmark pattern is detected.