Filter view not working

Dreykku commented 1 year ago

Hi, When clicking Filter view and then selecting the tags i specifically want to be displayed, i have nothing anymore. Rather, all the bookmarks disappear, Inline bookmark tab becomes just empty. After a few minutes/seconds, it automatically reset to the original point. But still impossible to filter anything.

After the vscode update bug, i thought it came from me, and tried to change a few things in option. I'm pretty sure i reverted all options back once the update bug has been fixed but it's possible it comes from me. What option could have caused this (in case it only comes from me)?

Thanks.

chaukhoa97 commented 1 year ago

Please fix this, filter is the killing part of the extension and now it just doesn't work

thekie commented 1 year ago

Not working for me as well.

brown-qs commented 1 year ago

same here Please fix this asao

sebastiantf commented 1 year ago

It used to work at first, but stopped working from later on

abulka commented 9 months ago

Not working for me either, fresh install of the extension on a Mac. The ability to filter is critical.

mrlee14 commented 6 months ago

same here... not working

error9900 commented 5 months ago

Still not working... Looks like last commit to repo was Oct 10 2022...

EDIT: Weird... Within VSCode, it claims the Extension was Last updated on 2024-02-04, 21:41:59, but everything else seems to indicate otherwise... It says 2022 here, so I wonder where VSCode is pulling that date from...

daniel347x commented 4 weeks ago

Bummer. This is the only bookmarks extension I know of that simply uses saved comments in the source code itself. Obviously, the feature to filter on bookmarks is critical and given that this is now broken, I think we must accept that unless somebody takes ownership to maintain this extension, it is becoming deprecated and we should move on.

daniel347x commented 4 weeks ago

I have fixed the bug and issued a PR:

https://github.com/tintinweb/vscode-inline-bookmarks/pull/79

I hope that the maintainer either approves the PR or turns over ownership of the project to someone who has time. This is an immensely useful extension and I think it should be maintained so that it continues to work.

In the meantime, my fork of the repository, with the fix (provided for the above PR), is available here:

https://github.com/daniel347x/vscode-inline-bookmarks/tree/patch-1

Apologies that I do not have time to provide integration instructions to build and load my fork into Visual Code - I am very busy and not very experienced with writing VS Code extensions. However, I was able to get my above fork built and installed into my own installation of Visual Code to test that it resolves the problem.

daniel347x commented 4 weeks ago

OK, here are instructions how to install the corrected repository from my fork:

Uninstall the existing extension first.
Recommended: Use WSL in Windows for the following if you use VS Code on Windows; it works fine
Clone my fork (git clone https://github.com/daniel347x/vscode-inline-bookmarks)
cd to the root of the repository and checkout the correct branch (git checkout patch-1)
Make sure to install latest Node.js; do not use the default version or it will fail; steps follow:

From https://nodejs.org/en/download/package-manager:

curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.7/install.sh | bash (but check the above link for the latest version and use that instead of v0.39.7)

exit (Exit the shell and restart it for the new installation to be easily available at the command line)

nvm install 20 (This installs Node v20 and npm v10. But again, check the above link for the latest version and use that instead of 20)

Confirm the versions, as noted at the above link: node -v npm -v

Now proceed to build the .vsix installer. From the root of the cloned repository (above):

npm install (This builds the actual extension)
npm install -g vsce (This installs the tool that generates the .vsix installer for the extension)
vsce package (This builds the .vsix installer)
Return to Visual Code and issue the command "Extension: Install from VSIX" (open the Commands window, Ctrl/Cmd+Shift+P, and type VSIX to reveal the command)

In the "File Open" dialog that appears, navigate to the root of the repository and select the .vsix file that was just created.

The installation should now be complete.

MattStarfield commented 6 days ago

Same issue here. I JUST started using Inline Bookmarks and burnt a few hours trying to figure out what I was doing wrong.

I really appreciate @daniel347x providing a fix, but tbh, I'm not going to jump through all of those hoops, then, (ideally) end up reinstalling this proper extension when (if?) they decide to merge his fix.

Hopefully they'll just issue an update with his fix soon!!

tintinweb / vscode-inline-bookmarks

Filter view not working #59