Throw exception on missing configmap during initial load (fixes #88)

tintoy / dotnet-kube-client

A Kubernetes API client for .NET Standard / .NET Core

MIT License

192 stars 33 forks source link

Throw exception on missing configmap during initial load (fixes #88) #89

Closed PhilippCh closed 5 years ago

tintoy commented 5 years ago

Hi - thanks for contributing! Are you able to run the tests locally? The CI test run seems to be hanging on this branch...

tintoy commented 5 years ago

PS. Sorry to leave you hanging but I’m about to go to bed (I’m in the AU time zone), will pick this up first thing tomorrow morning :)

PhilippCh commented 5 years ago

Unit tests seem to be all-green locally. I think Travis completed just now as well. No worries, let me know if the PR is okay like that or if I should revise something :)

tintoy commented 5 years ago

I've added a small tweak to to your changes - can you have a look over it and let me know if you're happy with that? Hopefully it's still doing what you wanted :)

PhilippCh commented 5 years ago

Thanks a lot, that's still working for me! Sorry I didn't get back to you sooner, I couldn't find the time the last couple days.

tintoy commented 5 years ago

No problem :)

Will merge and publish this afternoon.

tintoy commented 5 years ago

Sorry for the delay - been a busy week!

PhilippCh commented 5 years ago

Thanks a lot for merging! Would you mind publishing to NuGet as well? Do you have a release schedule this could fit in?

tintoy commented 5 years ago

Published v2.2.15 (may take a while for packages to be indexed on NuGet) 😀

PhilippCh commented 5 years ago

Thank you!