search

tintoy / msbuild-project-tools-server

Language server for MSBuild intellisense (including PackageReference completion).
MIT License
59 stars 16 forks source link

Get rid of `DisposableObject` #69

Closed DoctorKrolic closed 1 year ago

DoctorKrolic commented 1 year ago

DisposableObject was used only for ActivityScope and by looking at code it seems like it didn't bring any value: its properties were only used in members, which were unused according to an IDE. So I just removed it all together. We don't work with unmanaged resources in this project, so we don't need any complicated dispose patterns anyway, just implementing IDisposable should be enough.

@tintoy Would like your approval on this

tintoy commented 1 year ago

The disposal pattern here is mainly for scoped "async-local" resources not unmanaged ones but yes - if there are no others like it for now then it's probably easier to just fold it into the derived class.

I believe System.Diagnostics has a useable activity scope these days so we might someday be able to use that instead.