search

tintoy / msbuild-project-tools-vscode

VS Code extension for MSBuild intellisense (including PackageReference completion).
MIT License
82 stars 16 forks source link

Use dotnet runtime extension #112

Closed DoctorKrolic closed 12 months ago

DoctorKrolic commented 12 months ago

Closes https://github.com/tintoy/msbuild-project-tools-vscode/issues/89

I managed to test this change on a PC without .NET 6 installed. As expected, current release version of extension just refused to work, while the version after changes in this PR started without any complaints. The language server itself spawns .NET sub-processes assuming that global dotnet command exists and can run .NET 6 assemblies, so the extension won't fully work on PC without .NET 6. However, since this is for task reflection stuff, which is soon gonna be merged for in-process execution, I didn't do anything special for it. If we managed to get rid of sub-process spawning, we are good. Otherwise we can pass .NET path to language server via environment variables later

tintoy commented 12 months ago

Nice one!

Related: tintoy/msbuild-project-tools-vscode#89

tintoy commented 12 months ago

Thanks!