tintoy / msbuild-project-tools-vscode

VS Code extension for MSBuild intellisense (including PackageReference completion).
MIT License
82 stars 16 forks source link

Remove unused dependencies #116

Closed DoctorKrolic closed 11 months ago

DoctorKrolic commented 11 months ago

These dependencies seem to be not used, so there is no need to include them into extension build

@tintoy i am not as much master of Node as I am of C#, so I would like your approval on this PR)

Closes https://github.com/tintoy/msbuild-project-tools-vscode/pull/81

tintoy commented 11 months ago

Some of those may now be coming in as a result of indirect dependencies now.

If you're able to run vsce package (https://www.npmjs.com/package/@vscode/vsce) and don't get any compile errors then it's fine to remove them 🙂

DoctorKrolic commented 11 months ago

Yes, vsce package works. Not only that, but the resulted vsix size is a lot lower (2.27MB -> 241KB). + resolved dependabot alert. So this is 100% a good change

tintoy commented 11 months ago

Thanks!