Enable all kinds of completions by default

tintoy / msbuild-project-tools-vscode

VS Code extension for MSBuild intellisense (including PackageReference completion).

MIT License

82 stars 16 forks source link

Enable all kinds of completions by default #128

Closed DoctorKrolic closed 9 months ago

DoctorKrolic commented 9 months ago

Since target/task completions no longer cause perf problems as they are moved to in-process handling, we should enable them by default. Users can opt out if necessary. In the long run, I believe, we should remove this option entirely (imagine if C# had such option for every type of completions and some of them were off by default). But it should stay for at least 1 release, so if there are problems with it, we can guide users to disable these types of completions and fix the underlying issue.

tintoy commented 9 months ago

(also, agree with you about leaving it configurable as a switch until the subsequent release)