tintoy / msbuild-project-tools-vscode

VS Code extension for MSBuild intellisense (including PackageReference completion).
MIT License
82 stars 16 forks source link

Pack extension #133

Closed DoctorKrolic closed 7 months ago

DoctorKrolic commented 7 months ago

Verified, that debugging of extension client is working. Verified, that vsce package produces a valid vsix, so if extension is installed from that vsix it is fully functional.

DoctorKrolic commented 7 months ago

@tintoy I encourage you not only to review the code but to download this branch locally and make same verifications as I did (try to launch extension in debug mode and ensure breakpoints are hit; build vsix, install it locally and ensure extension works) to double-check that everything is working as expected

DoctorKrolic commented 7 months ago

I'm getting a webpack warning whn building extension. Filled https://github.com/microsoft/vscode-languageserver-node/issues/1355. Gonna hold this until we get a confirmation, that this is safe and we aren't gonna break anything