search

tintoy / msbuild-project-tools-vscode

VS Code extension for MSBuild intellisense (including PackageReference completion).
MIT License
82 stars 16 forks source link

Extension Package (VSIX) size is bit big! #37

Closed Nirmal4G closed 6 years ago

Nirmal4G commented 6 years ago

The current package contains entire source code tree and including the pdb/xml files which causes the package size to be >10Mb!

Is this intended? If so Why?

If not, Can we not include unnecessary files, I know the license states that you include source distribution but that's why we have git/GitHub and commit hashes right?

Would be easier to tag'em and put the hash in the ChangeLog?

tintoy commented 6 years ago

Hmm, not really intentional, although for a nodejs app we do have to include node_modules, which probably blows out the size a bit... We certainly don't need to include any C# source code, so feel free to open a PR to modify .vscodeignore as required :)

tintoy commented 6 years ago

From memory, all that the extension package needs to contain is package.json, node_modules, help/, and everything under out/.

tintoy commented 6 years ago

PDB files are required for useful stack-traces, but we can also probably strip out PDB files for any assemblies that aren't ours (assuming the package contains any).

tintoy commented 6 years ago

Ok - that's more than halved it to around 5MB :)

tintoy commented 6 years ago

And that's probably all we can strip out. The PDB files are high-value, and take up comparatively little space (none are larger than 50KB).

Nirmal4G commented 6 years ago

I got it around 5.3Mb when I was working SDK docs concept (BTW It's almost done), that's why I asked.

Anyway thanks! Can I Close it?

tintoy commented 6 years ago

Yep, thanks! About to publish v0.2.38 to the marketplace :)