Fix incorrect handling of non-Windows line endings

tintoy / msbuild-project-tools-vscode

VS Code extension for MSBuild intellisense (including PackageReference completion).

MIT License

83 stars 17 forks source link

Fix incorrect handling of non-Windows line endings #4

Closed tintoy closed 7 years ago

tintoy commented 7 years ago

Caused by Microsoft.Language.Xml.

Previously the parser used Environment.NewLine but this causes portability issues because on non-Windows systems that's \n (instead of \r\n), leading to different calculations of absolute position within the source text.

tintoy commented 7 years ago

Fixed in KirillOsenkov/XmlParser#11 (PR is KirillOsenkov/XmlParser#13).