tintoy / seqlog

Python logging integration for Seq (https://getseq.net)
https://seqlog.readthedocs.io/
MIT License
17 stars 11 forks source link

Type hint on set_global_log_properties #60

Closed robin523790 closed 1 year ago

robin523790 commented 1 year ago

Description

NOTE: This is only a display error in PyCharm. Execution of the code works fine, and neither VSCode nor pylance nor pyright report any issues.

PyCharm reports a type error on set_global_log_properties():

image

This is because the type is defined as dict[str, dict] instead of dict[str, str] in the comment:

image

Suggested solution

According to https://peps.python.org/pep-0484/#arbitrary-argument-lists-and-default-argument-values it should be OK to change the type to str... and in fact, the error goes away.

tintoy commented 1 year ago

Thanks for reporting! I'll get this done tomorrow morning 🙂

tintoy commented 1 year ago

Published v0.3.29 🙂

Vacant0mens commented 1 year ago

merged and published. closing this issue.