search

tinue / apa102-pi

Pure Python library to drive APA102 LED stripes; Use with Raspberry Pi.
GNU General Public License v2.0
201 stars 71 forks source link

spi.max_speed_hz should be parameterized #18

Closed DurandA closed 7 years ago

DurandA commented 7 years ago

This library works very well on the C.H.I.P. but I had to reduce the spi speed to 500 KHz. Would you accept a pull request which add max_speed_hz=8000000 to the APA102 constructor?

Side node: snake_case is recommended for variables and function names; see PEP 8.

tinue commented 7 years ago

Sure, please go ahead! I might need a week or two, but I would certainly accept this change. Thanks for the hint about snake_case: Maybe it's obvious that I am a Java programmer on my day job ;)