search

tinue / apa102-pi

Pure Python library to drive APA102 LED stripes; Use with Raspberry Pi.
GNU General Public License v2.0
202 stars 72 forks source link

Add install-requires to project (Adafruit GPIO is on pypi!) #34

Closed nielstron closed 5 years ago

nielstron commented 5 years ago

This is a very nice and usable project, I would love to see in on pypi (installing via pypi). As Adafruit GPIO is there already, it would be possible to upload this project when adding this line to setup.py.

tinue commented 5 years ago

Thank you, I will have a look at your pull request!

I am a bit concerned about the Adafruit library. Limor states "this library is about to be deprecated, MacOS / FTDI keeps breaking stuff :( we'll try to implement ft232h for circuitpython. hopefully there's some FTDI library that works" (https://github.com/adafruit/Adafruit_Python_GPIO/issues/87).

I am nor sure if this concerns the entire GPIO library, or just the FTDI part for the Mac.

I am currently testing another GPIO library in branch "gpiozero", but the performance is terrible at the moment.

tinue commented 5 years ago

Thanks again for the pull request. I tested and merged your changes; So far so good. I close the request now, even though the library is not yet on pypi. I'll have to research this first...

tinue commented 5 years ago

In case you missed it: The library is now available on PyPi. If you have time I'd appreciate your feedback if it is working. Thanks!