search

tinue / apa102-pi

Pure Python library to drive APA102 LED stripes; Use with Raspberry Pi.
GNU General Public License v2.0
201 stars 71 forks source link

Develop #50

Closed RubenMomoa closed 2 years ago

RubenMomoa commented 3 years ago

added a way to select between hardware spi and bitbanging and removed the automatic selection added the hardware spi devices from spiPorts (lib Adafruit_Blinka) added global_brightness as param to init

tinue commented 3 years ago

Thank you, I like your changes. This allows to use the additional hardware SPI devices of the Raspberry Pi 4. I wonder how often people change the global brightness while using the strip. Probably not very often, so having the parameter in the constructor is a good approach. I'll analyse the pull request in some more detail and will merge it afterwards. Thanks again and best regards, Martin

RubenMomoa commented 3 years ago

Thank you for the feed back for the global brightness i was kind of think its 1 less function to call but it doesn't matter much to me

and some use full info about all the hardware SPI buses on the raspberry pi here and here