tinuzz / wp-plugin-trackserver

A WordPress plugin for GPS tracking and publishing
https://wordpress.org/plugins/trackserver/
36 stars 12 forks source link

introduce tsmap placeholders distancem and distancekm #23

Closed wrohdewald closed 6 years ago

wrohdewald commented 6 years ago

I did not change translation strings. And I am not sure about miles. distancem clearly is the distance in meters, but what is the correct name for miles?

Please not that the help text did not yet mention {distance} at all, maybe {distance} can be removed. {speedX} placeholders always include the unit in their name, so maybe it should be the same with {distanceX}

tinuzz commented 6 years ago

I'd say 'distancemi'. I'll add this!

tinuzz commented 6 years ago

Also, I think it's not necessary to add new metadata in the server response. These values can be derived from the distance in meters, so they can just be calculated in JS.