tiny-pilot / ansible-role-tinypilot

DEPRECATED: Merged into core tiny-pilot/tinypilot repo
https://tinypilotkvm.com
MIT License
118 stars 37 forks source link

Update Overhaul: host `get-tinypilot.sh` script ourselves? #216

Open jotaen4tinypilot opened 1 year ago

jotaen4tinypilot commented 1 year ago

When performing a system update, the privileged update script is hard-wired to Github (https://raw.githubusercontent.com).

I’m wondering whether it would make sense to change this URL to a host that we control. The URL is distributed to devices and it might stay there for years (if people are lazy with system updates), which makes it very hard if not impossible to ever change anything about the URL.

Potential scenarios:

The most simple solution I can think of is to create a redirect route in gatekeeper that’s like https://gk.tinypilotkvm.com/get-tinypilot.sh, which issues a 307 redirect to https://raw.githubusercontent.com/tiny-pilot/tinypilot/master/get-tinypilot.sh. That way we wouldn’t have to mirror the script itself.

It would even be possible to version that URL, like https://gk.tinypilotkvm.com/get-tinypilot.sh?version=2.0. Not sure what this could be useful for, but it demonstrates that we might be more flexible.

mtlynch commented 1 year ago

I think this is a good thing to do, but I think it can wait until after the update overhaul is done. I want to get it wrapped up ASAP since it's been a long time between releases, and this isn't the kind of thing that necessarily has to happen in sync with the rest of the changes.