tiny-pilot / ansible-role-tinypilot

DEPRECATED: Merged into core tiny-pilot/tinypilot repo
https://tinypilotkvm.com
MIT License
117 stars 37 forks source link

Update Overhaul: Remove the use of the TinyPilot git repo in favor of the TinyPilot Debian package. #218

Closed jdeanwallace closed 1 year ago

jdeanwallace commented 2 years ago

After having merged both https://github.com/tiny-pilot/tinypilot/pull/1046 and https://github.com/tiny-pilot/ansible-role-tinypilot/pull/214, we can remove the use of git for TinyPilot code. For example:

jdeanwallace commented 2 years ago

Once we remove the TinyPilot repo and only rely on the TinyPilot Debian package, the build step fails because the TinyPilot Debian package is not part of this repo and only gets built in the tinypilot repo.

We could consider:

  1. Merging the ansible-role-tinypilot repo with the tinypilot repo (as suggested before)
    • This seems to be where we are going in the long run.
  2. Rebuild the TinyPilot Debian package as part of ansible-role-tinypilot's CI.
    • This should be easy copy paste work.
  3. Upload the TinyPilot Debian package somewhere so that we can reference it in the ansible playbook.
    • The file should have to be accessible via a static URL to avoid manually updating the reference.
mtlynch commented 2 years ago

I think we should:

  1. Fix collect-debug-logs now
  2. Mark the git install of ansible-role-tinypilot as deprecated
  3. Punt the removal of the git logic until later

We'll probably end up folding ansible-role-tinypilot into the tinypilot repo, but it's too much churn right now to add another big change.

jotaen4tinypilot commented 2 years ago

~Just for reference, tinypilot_repo_branch is no longer populated by the main tinypilot repo, so it’s safe to delete altogether.~

jdeanwallace commented 2 years ago

@jotaen4tinypilot – We can't remove the tinypilot_repo_branch variable from ansible-role-tinypilot yet because molecule still builds TinyPilot using the git repo. We first need a way to pass the TinyPilot Debian package to this repo's CircleCI build step. We'll most likely wait until we fold ansible-role-tinypilot into the tinypilot repo.