As discussed, we wanted to go with “solution 3”, which is to fold over the Janus-related logic from ansible-role-tinypilot to ansible-role-ustreamer. That way, ansible-role-ustreamer fully controls the Janus service, and is able to restart it after configuration changes. This is needed for applying an H264 bitrate change.
I added a fact determine whether to install Janus, in order to make the subsequent when conditions more concise and expressive. This is only temporary, though, because we are about to install Janus by default, in which case the ustreamer_install_janus fact will go away altogether.
The individual tasks are taken over as is from ansible-role-tinypilot. I only added some comments, to document how the order of the tasks depends on each other. In my initial version of this branch, I had put everything into janus.yml, to have it all closely together. But it turned out that didn’t work because of the (implicit) interdependencies.
As discussed, we wanted to go with “solution 3”, which is to fold over the Janus-related logic from
ansible-role-tinypilottoansible-role-ustreamer. That way,ansible-role-ustreamerfully controls the Janus service, and is able to restart it after configuration changes. This is needed for applying an H264 bitrate change.Notes:
ustreamer_with_h264to their settings file retroactively, and repurposingustreamer_compile_janus_pluginortinypilot_install_janusalso doesn’t make sense.determine whether to install Janus, in order to make the subsequentwhenconditions more concise and expressive. This is only temporary, though, because we are about to install Janus by default, in which case theustreamer_install_janusfact will go away altogether.ansible-role-tinypilot. I only added some comments, to document how the order of the tasks depends on each other. In my initial version of this branch, I had put everything intojanus.yml, to have it all closely together. But it turned out that didn’t work because of the (implicit) interdependencies.(See corresponding PR in
ansible-role-tinypilot.)