History box expands even if unticked

[danmed]

Tested in Firefox and Chrome (both latest) on Windows 10.

Navigate to the page, untick the history, start typing.. the box expands anyway.

[mtlynch]

Thanks! I'll see if I can reproduce this.

[somik123]

Confirmed issue on Vivaldi as well.

@mtlynch

Change lines 261 to 268 on app.js (https://github.com/mtlynch/tinypilot/blob/master/app/static/js/app.js) from:

function onDisplayHistoryChanged(evt) {
  if (evt.target.checked) {
    document.getElementById("recent-keys").style.visibility = "visible";
  } else {
    document.getElementById("recent-keys").style.visibility = "hidden";
    limitRecentKeys(0);
  }
}

to

function onDisplayHistoryChanged(evt) {
  if (evt.target.checked) {
    document.getElementById("recent-keys").style.display = "";
  } else {
    document.getElementById("recent-keys").style.display = "none";
    limitRecentKeys(0);
  }
}

Or, better yet, change it to use the function that you already declared:

function onDisplayHistoryChanged(evt) {
  if (evt.target.checked) {
    showElementById("recent-keys");
  } else {
    hideElementById("recent-keys");
    limitRecentKeys(0);
  }
}