tiny-pilot / tinypilot

Use your Raspberry Pi as a browser-based KVM.
https://tinypilotkvm.com
MIT License
3k stars 252 forks source link

H.264: Proposal for audio-related UI elements (status bar / menu item) #1277

Open jotaen4tinypilot opened 1 year ago

jotaen4tinypilot commented 1 year ago

This is blocked on https://github.com/tiny-pilot/tinypilot/issues/1276. (Update 2022-01-26: On hold for the time being, as that ticket is “won’t fix”.)

We could display some sort of indication in the UI whether or not audio is currently playing. This might otherwise be ambiguous, because when it’s silent, the user cannot tell whether that’s due to the target machine not emitting any audio, or due to the streaming connection being severed.

An additional benefit is that such an indicator would promote discoverability of the feature.

Proposal

I think the most natural place for such an indication would be in the status bar. We could distinguish 3 cases:

For the first two cases, the UI could look like below. For the third case, we could just hide that element altogether.

audio on

audio off

Whether or not audio is muted could be controlled via a menu item:

Screenshot 2023-01-23 at 19 09 10

(Could also be phrased inversely, i.e. “Mute Audio”.)

Additional Notes

jotaen4tinypilot commented 1 year ago

(Removed this from the 2.5.4 project for now, since we can’t add an indicator without being able to detect audio capability.)