tiny-pilot / tinypilot

Use your Raspberry Pi as a browser-based KVM.
https://tinypilotkvm.com
MIT License
3.01k stars 252 forks source link

Drop the use of the uStreamer port Ansible variable #1563

Closed jdeanwallace closed 1 year ago

jdeanwallace commented 1 year ago

Related https://github.com/tiny-pilot/tinypilot/issues/1551

In https://github.com/tiny-pilot/tinypilot/pull/1562, we're moving uStreamer from port 8001 to port 48001. However, before we do that I thought it might be a good time to hardcode the port number and enforce non-user-configurability drop the use of the ustreamer_port Ansible variable.

According to https://github.com/tiny-pilot/tinypilot-pro/issues/972, ustreamer_port is already considered a non-user-configurable variable. This PR enforces ustreamer_port as being non-user-configurable.

This PR does the following:

Notes

  1. TinyPilot Pro would require the following additional change:

    # debian-pkg/debian/tinypilot.postinst
    
     KEYBOARD_PATH = '{{ tinypilot_keyboard_interface }}'
     MOUSE_PATH = '{{ tinypilot_mouse_interface }}'
    -USTREAMER_BASEURL = 'http://127.0.0.1:{{ ustreamer_port }}'
    +USTREAMER_BASEURL = 'http://127.0.0.1:8001'

    Review on CodeApprove

jdeanwallace commented 1 year ago
Automated comment from CodeApprove ➜

⏳ @mtlynch please review this Pull Request