Closed jdeanwallace closed 1 year ago
@mtlynch - I'm requesting a review from you because I see you're working on https://github.com/tiny-pilot/tinypilot/pull/1554, which touches the same files (and I suspect would also fix https://github.com/tiny-pilot/tinypilot/issues/1567)
⏳ @mtlynch please review this Pull Request
Resolves https://github.com/tiny-pilot/tinypilot/issues/1567
WebRTC audio streaming stopped working since https://github.com/tiny-pilot/tinypilot/pull/1470. The problem was that the uStreamer Janus plugin config file was being written before populating the
ustreamer_capture_device
variable, which resulted in no Janus audio config: https://github.com/tiny-pilot/tinypilot/blob/b379ac26ea87a99e6126b3d616648b905013cb2f/ansible-role-ustreamer/templates/janus.plugin.ustreamer.jcfg.j2#L5-L10The
ustreamer_capture_device
variable is populated when reading the/home/ustreamer/config.yml
file: https://github.com/tiny-pilot/tinypilot/blob/b379ac26ea87a99e6126b3d616648b905013cb2f/ansible-role-ustreamer/tasks/check_saved_settings.yml#L11-L14Back in https://github.com/tiny-pilot/tinypilot/pull/1470, I specifically mentioned that I was shifting where the TC358743 chip was being provisioned, but I incorrectly assumed that only the uStreamer launcher cared about the uStreamer config file:
This PR only writes the uStreamer Janus plugin config file after we have determined the uStreamer capture device.