Hardcode h264 parameters - Githubissues

tiny-pilot / tinypilot

Use your Raspberry Pi as a browser-based KVM.

https://tinypilotkvm.com

MIT License

3.01k stars 252 forks source link

Hardcode h264 parameters #1570

Closed mtlynch closed 1 year ago

mtlynch commented 1 year ago

We have three Ansible vars related to uStreamer's H264 settings that can be deleted and replaced with hardcoded values:

ustreamer_h264_sink
ustreamer_h264_sink_mode
ustreamer_h264_sink_rm

Deleting these vars impacts a few files:

We're conditioning a Janus install on these vars, but we should unconditionally install Janus.
We're conditioning uStreamer flags but we should unconditionally add those flags in this section
We're templating janus.plugin.ustreamer.jcfg with ustreamer_h264_sink but we can replace it with the hardcoded string of tinypilot::ustreamer::h264.

Background

See the Ansible-to-Debian refactoring doc. You should already have done an Ansible-to-Debian refactoring PR before taking on this one.