tiny-pilot / tinypilot

Use your Raspberry Pi as a browser-based KVM.
https://tinypilotkvm.com
MIT License
3.05k stars 255 forks source link

Remove explicit cma specification in /boot/cmdline.txt #1582

Closed db39 closed 1 year ago

db39 commented 1 year ago

Resolves #1580

This change removes ansible tasks that explicitly set 128MiB of CMA. They're no longer needed because RaspberryPi OS Bullseye now uses 512MiB by default.

To run this build:

curl \
  --silent \
  --show-error \
  --location \
  https://raw.githubusercontent.com/tiny-pilot/tinypilot/master/scripts/install-bundle | \
  sudo bash -s -- \
    https://output.circle-artifacts.com/output/job/d38fa2bc-26f1-448d-984e-6653963d20ad/artifacts/0/bundler/dist/tinypilot-community-20230823T1154Z-1.9.0-56+5b44790.tgz

You can check the CMA with this command:

dmesg | grep -i cma

Review on CodeApprove

db39 commented 1 year ago

I tested this on a fresh install of RaspberryPi OS Bullseye. I ran the build with:

curl \
  --silent \
  --show-error \
  --location \
  https://raw.githubusercontent.com/tiny-pilot/tinypilot/master/scripts/install-bundle | \
  sudo bash -s -- \
    https://output.circle-artifacts.com/output/job/d38fa2bc-26f1-448d-984e-6653963d20ad/artifacts/0/bundler/dist/tinypilot-community-20230823T1154Z-1.9.0-56+5b44790.tgz

Then checked the CMA (dmesg | grep -i cma):

[    0.000000] Reserved memory: created CMA memory pool at 0x000000000ec00000, size 512 MiB
[    0.000000] OF: reserved mem: initialized node linux,cma, compatible id shared-dma-pool
[    0.000000] Memory: 1185280K/1835008K available (11776K kernel code, 2106K rwdata, 3688K rodata, 4160K init, 1077K bss, 125440K reserved, 524288K cma-reserved)
[    5.110853] vc_sm_cma: module is from the staging directory, the quality is unknown, you have been warned.
[    5.121524] bcm2835_vc_sm_cma_probe: Videocore shared memory driver

And checked that video capture still works:

TinyPilot-2023-08-23T12 08 21 468Z

db39 commented 1 year ago
Automated comment from CodeApprove ➜

⏳ @mtlynch please review this Pull Request