search

tiny-pilot / tinypilot

Use your Raspberry Pi as a browser-based KVM.
https://tinypilotkvm.com
MIT License
3.01k stars 252 forks source link

Hardcode h264 parameters #1585

Closed db39 closed 1 year ago

db39 commented 1 year ago

Resolves #1570

This change removes uStreamer variables in the Ansible role and hardcodes them. We now also unconditionally install Janus.

To test this bundle, run:

curl \
  --silent \
  --show-error \
  --location \
  https://raw.githubusercontent.com/tiny-pilot/tinypilot/master/scripts/install-bundle | \
  sudo bash -s -- \
    https://output.circle-artifacts.com/output/job/8025923f-9ba2-4e45-aef0-952f0f12655b/artifacts/0/bundler/dist/tinypilot-community-20230824T1222Z-1.9.0-62+3908e48.tgz

Review on CodeApprove

db39 commented 1 year ago

@mtlynch - I've removed the uStreamer variables and hardcoded the values where required. It works as expected.

I've left the 'determine whether to install Janus' task in place since ustreamer_install_janus gets used elsewhere. We could remove all references to ustreamer_install_janus, but we'd have to consider the 'decide whether to support audio streaming' task which currently relies on the uStreamer install. We could hardcode this too.