search

tiny-pilot / tinypilot

Use your Raspberry Pi as a browser-based KVM.
https://tinypilotkvm.com
MIT License
3k stars 252 forks source link

Simplify and tidy up HTML in index.html #1586

Closed jotaen4tinypilot closed 1 year ago

jotaen4tinypilot commented 1 year ago

Part of https://github.com/tiny-pilot/tinypilot/issues/728, follow up of https://github.com/tiny-pilot/tinypilot/pull/1583. Non-functional refactoring.

https://github.com/tiny-pilot/tinypilot/pull/1583 left a stray <div> in the index.html file, which doesn’t serve any purpose anymore.

This PR removes the <div>, and lifts up the <remote-screen> and <on-screen-keyboard> components. That doesn’t have any actual effect, as all HTML elements are positioned absolutely anyway, but to me it makes for a slightly more intuitive code structure: i.e., we instantiate the basic elements in the order in which they appear on the screen, and have all dialog elements underneath. Review on CodeApprove

mtlynch commented 1 year ago
Automated comment from CodeApprove ➜

⏳ @jdeanwallace please review this Pull Request