tiny-pilot / tinypilot

Use your Raspberry Pi as a browser-based KVM.
https://tinypilotkvm.com
MIT License
3k stars 252 forks source link

Reimplement /boot/config.txt logic in postinst script #1602

Closed db39 closed 1 year ago

db39 commented 1 year ago

Resolves #1594

These changes remove some ansible tasks relating to the /boot/config.txt logic and re-implements them using tinypilot.postinst instead.

To test on a live device:

curl \
  --silent \
  --show-error \
  --location \
  https://raw.githubusercontent.com/tiny-pilot/tinypilot/master/scripts/install-bundle | \
  sudo bash -s -- \
    https://output.circle-artifacts.com/output/job/743a657b-dbde-48b6-912e-01ee511631f0/artifacts/0/bundler/dist/tinypilot-community-20230901T1138Z-1.9.0-72+c746cda.tgz

Review on CodeApprove

db39 commented 1 year ago

Thanks for mentioning that! I noticed render-template wasn't going to work without some modifications, so I thought it was a little odd to use it.

db39 commented 1 year ago

It looks like we can't quite remove all of the /boot/config.txt logic from ansible-role-ustreamer/tasks/main.yml because the configure TC358743 HDMI capture chip task relies on it.

It looks like the configure TC358743 HDMI capture chip task will be removed in #1598. Should I wait until that's complete?

mtlynch commented 1 year ago

It looks like we can't quite remove all of the /boot/config.txt logic from ansible-role-ustreamer/tasks/main.yml because the configure TC358743 HDMI capture chip task relies on it.

Ah, right.

It looks like the configure TC358743 HDMI capture chip task will be removed in #1598. Should I wait until that's complete?

No, how you have it now is good, and I'll remove the leftover /boot/config.txt stuff in #1598.

db39 commented 1 year ago

I tested installations with dtoverlay=tc358743 and without - both /boot/config.txt and /etc/janus/janus.plugin.ustreamer.jcfg contain the appropriate content after install.