tiny-pilot / tinypilot

Use your Raspberry Pi as a browser-based KVM.
https://tinypilotkvm.com
MIT License
3k stars 252 forks source link

Delete Ansible from installation process #1604

Closed mtlynch closed 1 year ago

mtlynch commented 1 year ago

Resolves #1598 Resolves #1596

This reimplements the load-tc358743-edid service without Ansible, which completes our process of eliminating Ansible from TinyPilot's install process.

The last real piece was moving the installation of the load-tc358743-edid from Ansible to Debian. The rest is just deleting remaining Ansible files and stray references to Ansible.

Note that in deleting the Ansible environment setup, we delete apt-get update --allow-releaseinfo-change-suite which we added in https://github.com/tiny-pilot/tinypilot/issues/764. I don't think we need this command anymore, but we can bring it back in the future if we find that we need it.

Manual tests

I ran the following manual tests:

For the following scenarios:

Peer testing

To test this bundle run:

curl \
  --silent \
  --show-error \
  --location \
  https://raw.githubusercontent.com/tiny-pilot/tinypilot/master/scripts/install-bundle | \
  sudo bash -s -- \
    https://output.circle-artifacts.com/output/job/a5f0e73a-fc7b-4025-b6ce-c8f05c4be707/artifacts/0/bundler/dist/tinypilot-community-20230901T1513Z-1.9.0-109+51dc0af.tgz && \
  sudo reboot

Review on CodeApprove

mtlynch commented 1 year ago
Automated comment from CodeApprove ➜

⏳ @jdeanwallace please review this Pull Request