tiny-pilot / tinypilot

Use your Raspberry Pi as a browser-based KVM.
https://tinypilotkvm.com
MIT License
3k stars 252 forks source link

Install yq without Ansible #1608

Closed mtlynch closed 1 year ago

mtlynch commented 1 year ago

Resolves #1595

As part of our continuing effort to eliminate Ansible from our install process, this installs yq from within the bundle installer rather than during Ansible.

This is a slight implementation change in that we no longer download the yq binary at install time and instead pre-download it and include it in the TinyPilot bundle. This is preferable, as it does more work in the packaging stage and less work on user devices, though it does increase the size of our bundles by a few megabytes.

While we're here, we're also upgrading to the latest version of yq, so we're upgrading from v4.30.6 to v4.35.1.

Manual tests

For expediency, I tested builds that combined:

For the manual tests, I verified:

In these environments:

Peer tests

To test this bundle (which combines the stack of three PRs mentioned above), run:

curl \
  --silent \
  --show-error \
  --location \
  https://raw.githubusercontent.com/tiny-pilot/tinypilot/master/scripts/install-bundle | \
  sudo bash -s -- \
    https://output.circle-artifacts.com/output/job/e70104a2-0f1f-43b7-abe9-098d6eac2799/artifacts/0/bundler/dist/tinypilot-community-20230831T0151Z-1.9.0-87+de1916a.tgz

Review on CodeApprove

mtlynch commented 1 year ago
Automated comment from CodeApprove ➜

⏳ @jdeanwallace please review this Pull Request